gianm commented on code in PR #19005:
URL: https://github.com/apache/druid/pull/19005#discussion_r2886541707
##########
extensions-contrib/grpc-query/src/main/java/org/apache/druid/grpc/server/QueryDriver.java:
##########
@@ -163,6 +190,7 @@ private QueryResponse runNativeQuery(QueryRequest request,
AuthenticationResult
Thread.currentThread().setName(StringUtils.format("grpc-native[%s]",
query.getId()));
final ByteString results = encodeNativeResults(request, sequence,
rowSignature);
+ // TODO: should we call queryLifecycle.emitLogsAndMetrics() here?
Review Comment:
Please don't commit TODO comments. In general
`queryLifecycle.emitLogsAndMetrics()` should be called any time a query is
done, regardless of whether it completes successfully, with an error, or with a
cancellation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
