kfaraz commented on code in PR #18480: URL: https://github.com/apache/druid/pull/18480#discussion_r2326395289
########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java: ########## @@ -49,6 +50,7 @@ public class LagBasedAutoScalerConfig implements AutoScalerConfig private final boolean enableTaskAutoScaler; private final long minTriggerScaleActionFrequencyMillis; private final AggregateFunction lagAggregate; + @Nullable private Double stopTaskCountPercent; Review Comment: Yes, the pattern suggested in that comment makes sense. I just meant we should drop the `@Nullable` from `@Nullable private Double stopTaskCountPercent` since none of the other fields have it and it doesn't serve any real purpose. It is important to have `@Nullable` in the public APIs like the getter and the constructor arg. ########## indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/autoscaler/LagBasedAutoScalerConfig.java: ########## @@ -49,6 +50,7 @@ public class LagBasedAutoScalerConfig implements AutoScalerConfig private final boolean enableTaskAutoScaler; private final long minTriggerScaleActionFrequencyMillis; private final AggregateFunction lagAggregate; + @Nullable private Double stopTaskCountPercent; Review Comment: Also, should this field be `final`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
