capistrant commented on code in PR #18451:
URL: https://github.com/apache/druid/pull/18451#discussion_r2319995737
##########
processing/src/main/java/org/apache/druid/segment/UnnestCursorFactory.java:
##########
@@ -475,6 +453,73 @@ public static ColumnCapabilities
computeOutputColumnCapabilities(
}
}
+ /**
+ * Converts a {@link CursorBuildSpec} to the base table {@link
CursorBuildSpec}, ensuring that all required columns
+ * of are added to {@link CursorBuildSpec#getPhysicalColumns()} and the
unnest column is added to {@link CursorBuildSpec#getVirtualColumns()}
Review Comment:
nit: `ensuring that all required columns of ? are added to ...` potentially
missing a word where `?` is?
##########
processing/src/main/java/org/apache/druid/segment/UnnestCursorFactory.java:
##########
@@ -475,6 +453,73 @@ public static ColumnCapabilities
computeOutputColumnCapabilities(
}
}
+ /**
+ * Converts a {@link CursorBuildSpec} to the base table {@link
CursorBuildSpec}, ensuring that all required columns
+ * of are added to {@link CursorBuildSpec#getPhysicalColumns()} and the
unnest column is added to {@link CursorBuildSpec#getVirtualColumns()}
+ */
+ @VisibleForTesting
+ public static CursorBuildSpec transformCursorBuildSpec(
Review Comment:
I don't see any usage outside of the `org.apache.druid.segment` package,
should this drop the `public` visibility since it is marked as
visiblefortesting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
