abhishekrb19 commented on PR #18449: URL: https://github.com/apache/druid/pull/18449#issuecomment-3234218978
>This has happened a few times now where PRs have broken CI/build. I wonder if we can somehow enforce a rebase from master prior to merging to ensure CI passes on an up-to-date version of the code. it would be good to at least have reviewers ask contributors to merge the latest into older branches before merging. I feel enabling up-to-date checks for the Druid repo might be overkill, since the CI runtime is a few hours. We can discuss this further on the dev mailing list. @jtuglu1, yes, it would be good to at least have reviewers ask contributors to merge the latest into older branches (~a week or so) before merging. I feel enabling up-to-date checks for the druid repo is a bit overkill as the CI runtime is a few hours. We can discuss this in the dev mailing list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
