abhishekrb19 commented on code in PR #18430:
URL: https://github.com/apache/druid/pull/18430#discussion_r2298506530
##########
sql/src/test/java/org/apache/druid/sql/calcite/util/FakeIndexTaskUtil.java:
##########
@@ -68,24 +70,29 @@ public static TestDataSet makeDS(ObjectMapper objectMapper,
File src)
}
}
- private static InputSource relativizeLocalInputSource(InputSource
inputSource, File projectRoot)
+ private static InputSource resolveLocalInputSource(InputSource inputSource,
File projectRoot)
{
if (!(inputSource instanceof LocalInputSource)) {
return inputSource;
}
LocalInputSource localInputSource = (LocalInputSource) inputSource;
- if (localInputSource.getBaseDir().isAbsolute()) {
- return inputSource;
- }
- File newBaseDir =
projectRoot.toPath().resolve(localInputSource.getBaseDir().toPath()).toFile();
return new LocalInputSource(
- newBaseDir,
+ resolveFile(projectRoot, localInputSource.getBaseDir()),
localInputSource.getFilter(),
- localInputSource.getFiles(),
+ localInputSource.getFiles().stream().map(f -> resolveFile(projectRoot,
f)).collect(Collectors.toList()),
localInputSource.getSystemFields()
);
}
+ private static File resolveFile(File projectRoot, @Nullable File file)
Review Comment:
nit: `@Nullable` annotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
