amaechler opened a new pull request, #18405:
URL: https://github.com/apache/druid/pull/18405

   ### Description
   
   This PR fixes two issues with structs and nested maps in Protobuf messages. 
I added the failing scenarios in the test cases first (first commit) to 
highlight the bugs, and then fixed the issues in the subsequent commits.
   
   #### Release note
   
   Fixed: Druid no longer fails to handle nested map values in Protobuf 
messages, and improves handling of top-level structs.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] a release note entry in the PR description.
   - [x] added comments explaining the "why" and the intent of the code 
wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold for [code 
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
 is met.
   - [x] been tested in a test Druid cluster.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to