kfaraz commented on PR #18395:
URL: https://github.com/apache/druid/pull/18395#issuecomment-3182109263
@gianm , at the time of the original PR #17545 , we only moved APIs that
mark segments as used or unused
as they were the only ones needed for consistent behaviour with segment
metadata caching enabled on the Overlord.
The list of updated APIs was called out in the original PR as well as the
docs PR #17999 .
But I must have missed it during the review of web-console changes in #18172.
#### Move this API?
I did have plans to eventually move this API to the Overlord too as it just
calls `overlordClient.runKillTask()`.
But I was undecided on the API path to use and some other details.
> it's odd for this one to remain on the Coordinator, given that GET and
DELETE on /druid/coordinator/v1/datasources/{datasource} (apparently its
parent) did move to the Overlord.
- `DELETE /coordinator/datasources/{datasource}/intervals/{interval}`
launches a `kill` task
- Whereas other `DELETE /druid/coordinator/v1/datasources/...` APIs mark
segments as unused
- Using DELETE method is also somewhat incorrect because a successful
response here doesn't indicate
successful deletion of any resource, just that a task was submitted to the
Overlord.
- Given that the API just translates to calling `/task` on the Overlord with
a simple payload as below,
__do we even need this API?__
```json
{
"type": "kill",
"dataSource": "<your-datasource>",
"interval": "<your-kill-interval>"
}
```
__Suggested next steps:__
- Mark this coordinator API as deprecated in Druid 35.
- Delete all of the deprecated coordinator APIs in Druid 36.
- Update web-console to call Overlord `/task` API with the payload suggested
above.
- This will be useful in the future, when we expose other `kill` task
options on the web-console such as specifying `versions` to kill etc.
- I don't think this warrants a patch release.
- We can call it out as a known issue in the docs and suggest mitigation
steps ("Submit a JSON task" option).
@gianm , @jtuglu1 , please let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
