gianm opened a new pull request, #18385:
URL: https://github.com/apache/druid/pull/18385

   Previously, ColumnarFrameCursorFactory's canVectorize method didn'tc 
consider virtual columns or aggregators from the CursorBuildSpec. This meant 
that it would potentially return true for situations where a virtual column or 
aggregator really couldn't vectorize, leading to failures later on when the 
query engine attempts to create a vector cursor.
   
   The change in RowFrameCursorFactory doesn't change any functionality, it 
just structures the code more clearly by moving the CursorHolder to an inner 
class instead of an anonymous class.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to