kfaraz commented on code in PR #18314:
URL: https://github.com/apache/druid/pull/18314#discussion_r2237218195
##########
server/src/main/java/org/apache/druid/client/BrokerServerView.java:
##########
@@ -436,4 +445,31 @@ public List<ImmutableDruidServer> getDruidServers()
.map(queryableDruidServer ->
queryableDruidServer.getServer().toImmutableDruidServer())
.collect(Collectors.toList());
}
+
+ private static RowKey getMetricKey(final DataSegment segment,
DruidServerMetadata serverMetadata)
Review Comment:
Nit: please either keep both args final or both non-final.
##########
server/src/main/java/org/apache/druid/server/coordinator/stats/Dimension.java:
##########
@@ -31,7 +31,6 @@ public enum Dimension
DUTY_GROUP("dutyGroup"),
DESCRIPTION("description"),
SERVER("server");
-
Review Comment:
Please revert this change.
##########
embedded-tests/src/test/java/org/apache/druid/testing/embedded/msq/EmbeddedMSQRealtimeQueryTest.java:
##########
@@ -177,7 +179,9 @@ void setUpEach()
agg -> agg.hasSumAtLeast(totalRows)
);
broker.latchableEmitter().waitForEvent(
- event -> event.hasDimension(DruidMetrics.DATASOURCE, dataSource)
+ event -> event.hasMetricName("serverview/segment/added")
+ .hasDimension(DruidMetrics.DATASOURCE, dataSource)
+ .hasValue(1)
Review Comment:
Nit: the value of this metric is always 1, so we can remove this condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
