clintropolis commented on code in PR #18281:
URL: https://github.com/apache/druid/pull/18281#discussion_r2226950338
##########
processing/src/main/java/org/apache/druid/segment/VirtualColumn.java:
##########
@@ -56,7 +58,9 @@
@JsonSubTypes(value = {
@JsonSubTypes.Type(name = "expression", value =
ExpressionVirtualColumn.class),
@JsonSubTypes.Type(name = "fallback", value = FallbackVirtualColumn.class),
- @JsonSubTypes.Type(name = "mv-filtered", value =
ListFilteredVirtualColumn.class)
+ @JsonSubTypes.Type(name = "mv-filtered", value =
ListFilteredVirtualColumn.class),
+ @JsonSubTypes.Type(name = "regex-filtered", value =
RegexFilteredVirtualColumn.class),
+ @JsonSubTypes.Type(name = "prefix-filtered", value =
PrefixFilteredVirtualColumn.class)
Review Comment:
while they probably work ok, i'm not sure it makes sense to use these
virtual columns if not using multi-value strings, so the type names of these
probably should include the `mv-` prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
