adarshsanjeev commented on code in PR #18121:
URL: https://github.com/apache/druid/pull/18121#discussion_r2182218382
##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/test/MSQTestOverlordServiceClient.java:
##########
@@ -379,4 +386,12 @@ public void closeTask(String taskId)
taskDetailsByTaskId.get(taskId).close();
}
+
+ /**
+ *
+ */
Review Comment:
Added a javadoc
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/WorkerImpl.java:
##########
@@ -394,6 +433,17 @@ private void handleNewWorkOrder(
kernelHolder.partitionBoundariesFuture =
runWorkOrder.getStagePartitionBoundariesFuture();
}
+ @SuppressWarnings("unchecked")
+ private void updateMetricDimensions(QueryDefinition queryDef)
+ {
+ Set<String> datasourceDim = (Set<String>)
queryMetricDimensions.computeIfAbsent(DruidMetrics.DATASOURCE, s -> new
HashSet<>());
+ Set<Interval> intervalDim = (Set<Interval>)
queryMetricDimensions.computeIfAbsent(DruidMetrics.INTERVAL, s -> new
HashSet<>());
+ for (StageDefinition stageDef : queryDef.getStageDefinitions()) {
+ datasourceDim.addAll(MSQMetricUtils.getDatasources(stageDef));
Review Comment:
Currently, I believe this is a one time need. Now that I have changed
getDatasources to a member of stageDefinition, maybe this isn't required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
