aho135 commented on code in PR #18169: URL: https://github.com/apache/druid/pull/18169#discussion_r2175714584
########## processing/src/test/java/org/apache/druid/segment/nested/StructuredDataTest.java: ########## @@ -95,6 +95,18 @@ public void testCompareTo() } + @Test + public void testCompareToWithDifferentJSONOrder() Review Comment: Thanks for the review @clintropolis! Sounds good, since key ordering during comparison is the minimal change to resolve the transitivity bug I'll revert to that. I do think in a follow up PR it could be worthwhile to have an option to sort keys at ingestion time though. I would imagine that this has some performance benefits at query time, especially for json with a large number of keys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
