This is an automated email from the ASF dual-hosted git repository.
kfaraz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 93add1b23ec Fix typos in `defaultMetricDimensions.json` for the
dropwizard emitter (#18129)
93add1b23ec is described below
commit 93add1b23ec9cd4d57f2d15469e76f3d8b2a0609
Author: Abhishek Radhakrishnan <[email protected]>
AuthorDate: Thu Jun 12 02:07:13 2025 -0700
Fix typos in `defaultMetricDimensions.json` for the dropwizard emitter
(#18129)
This patch:
1. Fixes typos in the `ingest/persists/*` metric names (`ingest/persist/*`
is incorrect) in the default
dropwizard metrics mapping.
2. Fix the metric suffixes `*/counter` -> `*/count`. Druid metrics don't
have the suffix `/counter`.
The type is still `counter`.
3. Removes the json reference of the metrics from `dropwizard.md`, since
the actual source of truth
is already linked via `defaultMetricDimensions.json` in the document.
---
docs/design/extensions-contrib/dropwizard.md | 571 +--------------------
.../main/resources/defaultMetricDimensions.json | 38 +-
2 files changed, 20 insertions(+), 589 deletions(-)
diff --git a/docs/design/extensions-contrib/dropwizard.md
b/docs/design/extensions-contrib/dropwizard.md
index 4c7ea0170f3..f68b055327d 100644
--- a/docs/design/extensions-contrib/dropwizard.md
+++ b/docs/design/extensions-contrib/dropwizard.md
@@ -91,573 +91,4 @@
druid.emitter.dropwizard.reporters=[{"type":"console","emitIntervalInSecs":30}"}
```
### Default Metrics Mapping
-Latest default metrics mapping can be found [here]
(https://github.com/apache/druid/blob/master/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDimensions.json)
-```json
-{
- "query/time": {
- "dimensions": [
- "dataSource",
- "type"
- ],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "query/node/time": {
- "dimensions": [
- "server"
- ],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "query/node/ttfb": {
- "dimensions": [
- "server"
- ],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "query/segment/time": {
- "dimensions": [],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "query/wait/time": {
- "dimensions": [],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "segment/scan/pending": {
- "dimensions": [],
- "type": "gauge"
- },
- "segment/scan/active": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/segmentAndCache/time": {
- "dimensions": [],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "query/cpu/time": {
- "dimensions": [
- "dataSource",
- "type"
- ],
- "type": "timer",
- "timeUnit": "NANOSECONDS"
- },
- "query/cache/delta/numEntries": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/delta/sizeBytes": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/delta/hits": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/delta/misses": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/delta/evictions": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/delta/hitRate": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/delta/averageBytes": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/delta/timeouts": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/delta/errors": {
- "dimensions": [],
- "type": "counter"
- },
- "query/cache/total/numEntries": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/cache/total/sizeBytes": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/cache/total/hits": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/cache/total/misses": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/cache/total/evictions": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/cache/total/hitRate": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/cache/total/averageBytes": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/cache/total/timeouts": {
- "dimensions": [],
- "type": "gauge"
- },
- "query/cache/total/errors": {
- "dimensions": [],
- "type": "gauge"
- },
- "ingest/events/thrownAway": {
- "dimensions": [
- "dataSource"
- ],
- "type": "counter"
- },
- "ingest/events/unparseable": {
- "dimensions": [
- "dataSource"
- ],
- "type": "counter"
- },
- "ingest/events/duplicate": {
- "dimensions": [
- "dataSource"
- ],
- "type": "counter"
- },
- "ingest/events/processed": {
- "dimensions": [
- "dataSource"
- ],
- "type": "counter"
- },
- "ingest/rows/output": {
- "dimensions": [
- "dataSource"
- ],
- "type": "counter"
- },
- "ingest/persist/counter": {
- "dimensions": [
- "dataSource"
- ],
- "type": "counter"
- },
- "ingest/persist/time": {
- "dimensions": [
- "dataSource"
- ],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "ingest/persist/cpu": {
- "dimensions": [
- "dataSource"
- ],
- "type": "timer",
- "timeUnit": "NANOSECONDS"
- },
- "ingest/persist/backPressure": {
- "dimensions": [
- "dataSource"
- ],
- "type": "gauge"
- },
- "ingest/persist/failed": {
- "dimensions": [
- "dataSource"
- ],
- "type": "counter"
- },
- "ingest/handoff/failed": {
- "dimensions": [
- "dataSource"
- ],
- "type": "counter"
- },
- "ingest/merge/time": {
- "dimensions": [
- "dataSource"
- ],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "ingest/merge/cpu": {
- "dimensions": [
- "dataSource"
- ],
- "type": "timer",
- "timeUnit": "NANOSECONDS"
- },
- "task/run/time": {
- "dimensions": [
- "dataSource",
- "taskType"
- ],
- "type": "timer",
- "timeUnit": "MILLISECONDS"
- },
- "segment/added/bytes": {
- "dimensions": [
- "dataSource",
- "taskType"
- ],
- "type": "counter"
- },
- "segment/moved/bytes": {
- "dimensions": [
- "dataSource",
- "taskType"
- ],
- "type": "counter"
- },
- "segment/nuked/bytes": {
- "dimensions": [
- "dataSource",
- "taskType"
- ],
- "type": "counter"
- },
- "segment/assigned/counter": {
- "dimensions": [
- "tier"
- ],
- "type": "counter"
- },
- "segment/moved/counter": {
- "dimensions": [
- "tier"
- ],
- "type": "counter"
- },
- "segment/dropped/counter": {
- "dimensions": [
- "tier"
- ],
- "type": "counter"
- },
- "segment/deleted/counter": {
- "dimensions": [
- "tier"
- ],
- "type": "counter"
- },
- "segment/unneeded/counter": {
- "dimensions": [
- "tier"
- ],
- "type": "counter"
- },
- "segment/cost/raw": {
- "dimensions": [
- "tier"
- ],
- "type": "counter"
- },
- "segment/cost/normalization": {
- "dimensions": [
- "tier"
- ],
- "type": "counter"
- },
- "segment/cost/normalized": {
- "dimensions": [
- "tier"
- ],
- "type": "counter"
- },
- "segment/loadQueue/size": {
- "dimensions": [
- "server"
- ],
- "type": "gauge"
- },
- "segment/loadQueue/failed": {
- "dimensions": [
- "server"
- ],
- "type": "gauge"
- },
- "segment/loadQueue/counter": {
- "dimensions": [
- "server"
- ],
- "type": "gauge"
- },
- "segment/dropQueue/counter": {
- "dimensions": [
- "server"
- ],
- "type": "gauge"
- },
- "segment/size": {
- "dimensions": [
- "dataSource"
- ],
- "type": "gauge"
- },
- "segment/overShadowed/counter": {
- "dimensions": [],
- "type": "gauge"
- },
- "segment/max": {
- "dimensions": [],
- "type": "gauge"
- },
- "segment/used": {
- "dimensions": [
- "dataSource",
- "tier",
- "priority"
- ],
- "type": "gauge"
- },
- "segment/usedPercent": {
- "dimensions": [
- "dataSource",
- "tier",
- "priority"
- ],
- "type": "gauge"
- },
- "jvm/pool/committed": {
- "dimensions": [
- "poolKind",
- "poolName"
- ],
- "type": "gauge"
- },
- "jvm/pool/init": {
- "dimensions": [
- "poolKind",
- "poolName"
- ],
- "type": "gauge"
- },
- "jvm/pool/max": {
- "dimensions": [
- "poolKind",
- "poolName"
- ],
- "type": "gauge"
- },
- "jvm/pool/used": {
- "dimensions": [
- "poolKind",
- "poolName"
- ],
- "type": "gauge"
- },
- "jvm/bufferpool/counter": {
- "dimensions": [
- "bufferpoolName"
- ],
- "type": "gauge"
- },
- "jvm/bufferpool/used": {
- "dimensions": [
- "bufferpoolName"
- ],
- "type": "gauge"
- },
- "jvm/bufferpool/capacity": {
- "dimensions": [
- "bufferpoolName"
- ],
- "type": "gauge"
- },
- "jvm/mem/init": {
- "dimensions": [
- "memKind"
- ],
- "type": "gauge"
- },
- "jvm/mem/max": {
- "dimensions": [
- "memKind"
- ],
- "type": "gauge"
- },
- "jvm/mem/used": {
- "dimensions": [
- "memKind"
- ],
- "type": "gauge"
- },
- "jvm/mem/committed": {
- "dimensions": [
- "memKind"
- ],
- "type": "gauge"
- },
- "jvm/gc/counter": {
- "dimensions": [
- "gcName",
- "gcGen"
- ],
- "type": "counter"
- },
- "jvm/gc/cpu": {
- "dimensions": [
- "gcName",
- "gcGen"
- ],
- "type": "timer",
- "timeUnit": "NANOSECONDS"
- },
- "ingest/events/buffered": {
- "dimensions": [
- "serviceName",
- "bufferCapacity"
- ],
- "type": "gauge"
- },
- "sys/swap/free": {
- "dimensions": [],
- "type": "gauge"
- },
- "sys/swap/max": {
- "dimensions": [],
- "type": "gauge"
- },
- "sys/swap/pageIn": {
- "dimensions": [],
- "type": "gauge"
- },
- "sys/swap/pageOut": {
- "dimensions": [],
- "type": "gauge"
- },
- "sys/disk/write/counter": {
- "dimensions": [
- "fsDevName"
- ],
- "type": "counter"
- },
- "sys/disk/read/counter": {
- "dimensions": [
- "fsDevName"
- ],
- "type": "counter"
- },
- "sys/disk/write/size": {
- "dimensions": [
- "fsDevName"
- ],
- "type": "counter"
- },
- "sys/disk/read/size": {
- "dimensions": [
- "fsDevName"
- ],
- "type": "counter"
- },
- "sys/net/write/size": {
- "dimensions": [],
- "type": "counter"
- },
- "sys/net/read/size": {
- "dimensions": [],
- "type": "counter"
- },
- "sys/fs/used": {
- "dimensions": [
- "fsDevName",
- "fsDirName",
- "fsTypeName",
- "fsSysTypeName",
- "fsOptions"
- ],
- "type": "gauge"
- },
- "sys/fs/max": {
- "dimensions": [
- "fsDevName",
- "fsDirName",
- "fsTypeName",
- "fsSysTypeName",
- "fsOptions"
- ],
- "type": "gauge"
- },
- "sys/mem/used": {
- "dimensions": [],
- "type": "gauge"
- },
- "sys/mem/max": {
- "dimensions": [],
- "type": "gauge"
- },
- "sys/storage/used": {
- "dimensions": [
- "fsDirName"
- ],
- "type": "gauge"
- },
- "sys/cpu": {
- "dimensions": [
- "cpuName",
- "cpuTime"
- ],
- "type": "gauge"
- },
- "coordinator-segment/counter": {
- "dimensions": [
- "dataSource"
- ],
- "type": "gauge"
- },
- "historical-segment/counter": {
- "dimensions": [
- "dataSource",
- "tier",
- "priority"
- ],
- "type": "gauge"
- },
- "jetty/numOpenConnections": {
- "dimensions": [],
- "type": "gauge"
- },
- "jetty/threadPool/total": {
- "dimensions": [],
- "type": "gauge"
- },
- "jetty/threadPool/idle": {
- "dimensions": [],
- "type": "gauge"
- },
- "jetty/threadPool/busy": {
- "dimensions": [],
- "type": "gauge"
- },
- "jetty/threadPool/isLowOnThreads": {
- "dimensions": [],
- "type": "gauge"
- },
- "jetty/threadPool/min": {
- "dimensions": [],
- "type": "gauge"
- },
- "jetty/threadPool/max": {
- "dimensions": [],
- "type": "gauge"
- },
- "jetty/threadPool/queueSize": {
- "dimensions": [],
- "type": "gauge"
- }
-}
-```
+Latest default metrics mapping can be found
[here](https://github.com/apache/druid/blob/master/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDimensions.json)
diff --git
a/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDimensions.json
b/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDimensions.json
index 919aaa38367..623cce0e3e8 100644
---
a/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDimensions.json
+++
b/extensions-contrib/dropwizard-emitter/src/main/resources/defaultMetricDimensions.json
@@ -154,33 +154,33 @@
],
"type": "counter"
},
- "ingest/persist/counter": {
+ "ingest/persists/count": {
"dimensions": [
"dataSource"
],
"type": "counter"
},
- "ingest/persist/time": {
+ "ingest/persists/time": {
"dimensions": [
"dataSource"
],
"type": "timer",
"timeUnit": "MILLISECONDS"
},
- "ingest/persist/cpu": {
+ "ingest/persists/cpu": {
"dimensions": [
"dataSource"
],
"type": "timer",
"timeUnit": "NANOSECONDS"
},
- "ingest/persist/backPressure": {
+ "ingest/persists/backPressure": {
"dimensions": [
"dataSource"
],
"type": "gauge"
},
- "ingest/persist/failed": {
+ "ingest/persists/failed": {
"dimensions": [
"dataSource"
],
@@ -235,31 +235,31 @@
],
"type": "counter"
},
- "segment/assigned/counter": {
+ "segment/assigned/count": {
"dimensions": [
"tier"
],
"type": "counter"
},
- "segment/moved/counter": {
+ "segment/moved/count": {
"dimensions": [
"tier"
],
"type": "counter"
},
- "segment/dropped/counter": {
+ "segment/dropped/count": {
"dimensions": [
"tier"
],
"type": "counter"
},
- "segment/deleted/counter": {
+ "segment/deleted/count": {
"dimensions": [
"tier"
],
"type": "counter"
},
- "segment/unneeded/counter": {
+ "segment/unneeded/count": {
"dimensions": [
"tier"
],
@@ -295,13 +295,13 @@
],
"type": "gauge"
},
- "segment/loadQueue/counter": {
+ "segment/loadQueue/count": {
"dimensions": [
"server"
],
"type": "gauge"
},
- "segment/dropQueue/counter": {
+ "segment/dropQueue/count": {
"dimensions": [
"server"
],
@@ -313,7 +313,7 @@
],
"type": "gauge"
},
- "segment/overShadowed/counter": {
+ "segment/overShadowed/count": {
"dimensions": [],
"type": "gauge"
},
@@ -365,7 +365,7 @@
],
"type": "gauge"
},
- "jvm/bufferpool/counter": {
+ "jvm/bufferpool/count": {
"dimensions": [
"bufferpoolName"
],
@@ -407,7 +407,7 @@
],
"type": "gauge"
},
- "jvm/gc/counter": {
+ "jvm/gc/count": {
"dimensions": [
"gcName",
"gcGen"
@@ -445,13 +445,13 @@
"dimensions": [],
"type": "gauge"
},
- "sys/disk/write/counter": {
+ "sys/disk/write/count": {
"dimensions": [
"fsDevName"
],
"type": "counter"
},
- "sys/disk/read/counter": {
+ "sys/disk/read/count": {
"dimensions": [
"fsDevName"
],
@@ -518,13 +518,13 @@
],
"type": "gauge"
},
- "coordinator-segment/counter": {
+ "coordinator-segment/count": {
"dimensions": [
"dataSource"
],
"type": "gauge"
},
- "historical-segment/counter": {
+ "historical-segment/count": {
"dimensions": [
"dataSource",
"tier",
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
