[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18906: [opt](FileCache) use modification time to determine whether the file is changed

[via GitHub]

github-actions[bot] commented on code in PR #18906:
URL: https://github.com/apache/doris/pull/18906#discussion_r1173568766


##########
be/src/vec/exec/varrow_scanner.cpp:
##########
@@ -95,6 +95,8 @@
     _file_description.path = range.path;
     _file_description.start_offset = range.start_offset;
     _file_description.file_size = range.__isset.file_size ? range.file_size : 
0;
+    _file_description.modification_time =
+            range.__isset.modification_time ? range.modification_time : 0;

Review Comment:
   warning: no member named 'modification_time' in 'doris::TBrokerRangeDesc' 
[clang-diagnostic-error]
   ```cpp
               range.__isset.modification_time ? range.modification_time : 0;
                                                       ^
   ```
   



##########
be/src/vec/exec/varrow_scanner.cpp:
##########
@@ -95,6 +95,8 @@ void VArrowScanner::_init_file_description(const 
TBrokerRangeDesc& range) {
     _file_description.path = range.path;
     _file_description.start_offset = range.start_offset;
     _file_description.file_size = range.__isset.file_size ? range.file_size : 
0;
+    _file_description.modification_time =
+            range.__isset.modification_time ? range.modification_time : 0;

Review Comment:
   warning: no member named 'modification_time' in 
'doris::_TBrokerRangeDesc__isset' [clang-diagnostic-error]
   ```cpp
               range.__isset.modification_time ? range.modification_time : 0;
                             ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org