hust-hhb opened a new pull request, #18894:
URL: https://github.com/apache/doris/pull/18894
# Proposed changes
Issue Number: close #xxx
## Problem summary
when org.apache.doris.load.routineload.RoutineLoadTaskInfo#beginTxn fail,
the txnId of RoutineLoadTaskInfo will still be -1, and in this case show
routine load task will throw an NPE and crash, it will be better to check if
transactionState is null or not, like what
org.apache.doris.service.FrontendServiceImpl#loadTxn2PCImpl do.
DatabaseTransactionMgr dbTransactionMgr =
Env.getCurrentGlobalTransactionMgr()
.getDatabaseTransactionMgr(database.getId());
TransactionState transactionState =
dbTransactionMgr.getTransactionState(request.getTxnId());
if (transactionState == null) {
throw new UserException("transaction [" + request.getTxnId() +
"] not found");
}
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at
[d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you
chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
