github-actions[bot] commented on code in PR #18652:
URL: https://github.com/apache/doris/pull/18652#discussion_r1173240704
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@ namespace fs = std::filesystem;
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
_disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
cache_settings.disposable_queue_elements,
60 * 60);
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
+ 7 * 24 * 60 * 60);
+ _normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
_normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
+ 7 * 24 * 60 * 60);
+ _normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
+ 24 * 60 * 60);
+
+ LOG(INFO) << fmt::format(
+ "file cache path={}, disposable queue size={} elements={}, index
queue size={} "
+ "elements={}, query queue "
+ "size={} elements={}",
+ cache_base_path, cache_settings.disposable_queue_size,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
cache_base_path, cache_settings.disposable_queue_size,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
+ 7 * 24 * 60 * 60);
+ _normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
+ 24 * 60 * 60);
+
+ LOG(INFO) << fmt::format(
+ "file cache path={}, disposable queue size={} elements={}, index
queue size={} "
+ "elements={}, query queue "
+ "size={} elements={}",
+ cache_base_path, cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements,
cache_settings.index_queue_size,
+ cache_settings.index_queue_elements,
cache_settings.query_queue_size,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
cache_settings.index_queue_elements,
cache_settings.query_queue_size,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
+ 7 * 24 * 60 * 60);
+ _normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
+ 24 * 60 * 60);
+
+ LOG(INFO) << fmt::format(
+ "file cache path={}, disposable queue size={} elements={}, index
queue size={} "
+ "elements={}, query queue "
+ "size={} elements={}",
+ cache_base_path, cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements,
cache_settings.index_queue_size,
+ cache_settings.index_queue_elements,
cache_settings.query_queue_size,
+ cache_settings.query_queue_elements);
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
cache_settings.query_queue_elements);
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
+ 7 * 24 * 60 * 60);
+ _normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
+ 24 * 60 * 60);
+
+ LOG(INFO) << fmt::format(
+ "file cache path={}, disposable queue size={} elements={}, index
queue size={} "
+ "elements={}, query queue "
+ "size={} elements={}",
+ cache_base_path, cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements,
cache_settings.index_queue_size,
+ cache_settings.index_queue_elements,
cache_settings.query_queue_size,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
cache_settings.index_queue_elements,
cache_settings.query_queue_size,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
_index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
+ 7 * 24 * 60 * 60);
+ _normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
+ 24 * 60 * 60);
+
+ LOG(INFO) << fmt::format(
+ "file cache path={}, disposable queue size={} elements={}, index
queue size={} "
+ "elements={}, query queue "
+ "size={} elements={}",
+ cache_base_path, cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements,
cache_settings.index_queue_size,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
cache_settings.disposable_queue_elements,
cache_settings.index_queue_size,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
_index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
+ 7 * 24 * 60 * 60);
+ _normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
_normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
##########
be/src/io/cache/block/block_lru_file_cache.cpp:
##########
@@ -63,15 +63,31 @@
namespace doris {
namespace io {
-LRUFileCache::LRUFileCache(const std::string& cache_base_path_,
- const FileCacheSettings& cache_settings_)
- : IFileCache(cache_base_path_, cache_settings_) {}
+LRUFileCache::LRUFileCache(const std::string& cache_base_path,
+ const FileCacheSettings& cache_settings)
+ : IFileCache(cache_base_path, cache_settings) {
+ _disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements, 60
* 60);
+ _index_queue = LRUQueue(cache_settings.index_queue_size,
cache_settings.index_queue_elements,
+ 7 * 24 * 60 * 60);
+ _normal_queue = LRUQueue(cache_settings.query_queue_size,
cache_settings.query_queue_elements,
+ 24 * 60 * 60);
+
+ LOG(INFO) << fmt::format(
+ "file cache path={}, disposable queue size={} elements={}, index
queue size={} "
+ "elements={}, query queue "
+ "size={} elements={}",
+ cache_base_path, cache_settings.disposable_queue_size,
+ cache_settings.disposable_queue_elements,
cache_settings.index_queue_size,
Review Comment:
warning: member access into incomplete type 'const
doris::io::FileCacheSettings' [clang-diagnostic-error]
```cpp
cache_settings.disposable_queue_elements,
cache_settings.index_queue_size,
^
```
**be/src/io/cache/block/block_file_cache_fwd.h:34:** forward declaration of
'doris::io::FileCacheSettings'
```cpp
struct FileCacheSettings;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
