github-actions[bot] commented on code in PR #18796:
URL: https://github.com/apache/doris/pull/18796#discussion_r1172288449
##########
be/test/io/fs/buffered_reader_test.cpp:
##########
@@ -74,13 +74,49 @@ class SyncLocalFileReader : public io::FileReader {
std::mutex _lock;
};
+class MockOffsetFileReader : public io::FileReader {
+public:
+ MockOffsetFileReader(size_t size) : _size(size) {};
+
+ ~MockOffsetFileReader() = default;
Review Comment:
warning: annotate this function with 'override' or (rarely) 'final'
[modernize-use-override]
```suggestion
~MockOffsetFileReader() override = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
