CalvinKirs commented on PR #18666: URL: https://github.com/apache/doris/pull/18666#issuecomment-1510010170
> The multiple loop in the PatternGenerator#generateTypePattern is for readability, this function will invoke in the compile time so is not the hot point.↳ I know, I just replace `IntegerRange`,but even with the current approach, I don't think it has increased the complexity of the code. right? > > Maybe we should use `java.util.stream.IntStream.rangeClosed()` to replace the `IntRange`↳ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
