github-actions[bot] commented on code in PR #18369:
URL: https://github.com/apache/doris/pull/18369#discussion_r1165372150
##########
be/src/vec/functions/function.h:
##########
@@ -300,11 +302,14 @@ class IFunctionBuilder {
using FunctionBuilderPtr = std::shared_ptr<IFunctionBuilder>;
+/// used in function_factory. when we register a function, save a builder. to
get a function, to get a builder.
+/// will use DefaultFunctionBuilder as the default builder in function's
registration if we didn't explicitly specify.
class FunctionBuilderImpl : public IFunctionBuilder {
public:
FunctionBasePtr build(const ColumnsWithTypeAndName& arguments,
const DataTypePtr& return_type) const final {
Review Comment:
warning: non-virtual member function marked 'final' hides virtual member
function [clang-diagnostic-error]
```cpp
const DataTypePtr& return_type) const final {
^
```
**be/src/vec/functions/function.h:285:** hidden overloaded virtual function
'doris::vectorized::IFunctionBuilder::build' declared here: different number of
parameters (3 vs 2)
```cpp
virtual FunctionBasePtr build(const ColumnsWithTypeAndName& arguments,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
