CalvinKirs commented on PR #18448: URL: https://github.com/apache/doris/pull/18448#issuecomment-1501676552
> > Hi @hailin0 Thanks for your contribution. There are some issues:↳ > > > > 1. We prefer using 4 spaces instead tab for intent, could you please change it? > > 2. How to run `extension/beats/doris/doris_integration_test.go`? Please give an example so that I can add it to regression test. > > 3. `extension/beats/go.mod ` missing license header, please add it. you should update this file https://github.com/apache/doris/blob/master/.licenserc.yaml#L6, Then we will skip the checking of these two files. > > I see logstash plugin, how does he do the test↳ > > https://github.com/apache/doris/tree/master/extension/logstash -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
