HappenLee commented on code in PR #18354: URL: https://github.com/apache/doris/pull/18354#discussion_r1160396048
########## be/src/vec/functions/function_date_or_datetime_computation.h: ########## @@ -1001,6 +1002,24 @@ struct CurrentTimeImpl { } }; +struct TimeToSecImpl { + using ReturnType = DataTypeInt32; + static constexpr auto name = "time_to_sec"; + static Status execute(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + size_t result, size_t input_rows_count) { + auto res_col = ColumnVector<Int32>::create(); + auto argument_column = Review Comment: do not use `convert_to_full_column_if_const` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org