zclllyybb commented on code in PR #18310:
URL: https://github.com/apache/doris/pull/18310#discussion_r1159826375


##########
be/src/vec/functions/function_json.cpp:
##########
@@ -244,17 +244,44 @@ struct GetJsonNumberType {
         for (size_t i = 0; i < size; ++i) {
             const char* l_raw_str = reinterpret_cast<const 
char*>(&ldata[loffsets[i - 1]]);
             int l_str_size = loffsets[i] - loffsets[i - 1];
-

Review Comment:
   it has other common dependencies. found another way to extract common logic.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to