github-actions[bot] commented on code in PR #17820:
URL: https://github.com/apache/doris/pull/17820#discussion_r1151477287
##########
be/src/vec/data_types/data_type_bitmap.h:
##########
@@ -72,7 +72,7 @@ class DataTypeBitMap : public IDataType {
}
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
- [[noreturn]] virtual Field get_default() const override {
+ virtual Field get_default() const override {
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Field get_default() const override {
```
##########
be/src/vec/data_types/data_type_quantilestate.h:
##########
@@ -70,7 +70,7 @@ class DataTypeQuantileState : public IDataType {
}
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
- [[noreturn]] virtual Field get_default() const override {
+ virtual Field get_default() const override {
Review Comment:
warning: 'virtual' is redundant since the function is already declared
'override' [modernize-use-override]
```suggestion
Field get_default() const override {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
