morningman commented on code in PR #17884:
URL: https://github.com/apache/doris/pull/17884#discussion_r1147044720
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/RefreshManager.java:
##########
@@ -19,26 +19,48 @@
import org.apache.doris.analysis.CreateTableStmt;
import org.apache.doris.analysis.DropTableStmt;
+import org.apache.doris.analysis.RefreshCatalogStmt;
import org.apache.doris.analysis.RefreshDbStmt;
import org.apache.doris.analysis.RefreshTableStmt;
import org.apache.doris.analysis.TableName;
import org.apache.doris.catalog.external.ExternalDatabase;
import org.apache.doris.common.DdlException;
+import org.apache.doris.common.ThreadPoolManager;
import org.apache.doris.common.UserException;
import org.apache.doris.datasource.CatalogIf;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.ExternalObjectLog;
import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.qe.DdlExecutor;
+import com.google.common.collect.Maps;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import java.util.Map;
+import java.util.concurrent.ScheduledThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
// Manager for refresh database and table action
-public class RefreshManager {
+public class RefreshManager implements Runnable {
private static final Logger LOG =
LogManager.getLogger(RefreshManager.class);
+ private static final ScheduledThreadPoolExecutor REFRESH_Timer =
ThreadPoolManager.newDaemonScheduledThreadPool(1,
Review Comment:
```suggestion
private static final ScheduledThreadPoolExecutor REFRESH_TIMER =
ThreadPoolManager.newDaemonScheduledThreadPool(1,
```
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/RefreshManager.java:
##########
@@ -19,26 +19,48 @@
import org.apache.doris.analysis.CreateTableStmt;
import org.apache.doris.analysis.DropTableStmt;
+import org.apache.doris.analysis.RefreshCatalogStmt;
import org.apache.doris.analysis.RefreshDbStmt;
import org.apache.doris.analysis.RefreshTableStmt;
import org.apache.doris.analysis.TableName;
import org.apache.doris.catalog.external.ExternalDatabase;
import org.apache.doris.common.DdlException;
+import org.apache.doris.common.ThreadPoolManager;
import org.apache.doris.common.UserException;
import org.apache.doris.datasource.CatalogIf;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.ExternalObjectLog;
import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.qe.DdlExecutor;
+import com.google.common.collect.Maps;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import java.util.Map;
+import java.util.concurrent.ScheduledThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
// Manager for refresh database and table action
-public class RefreshManager {
+public class RefreshManager implements Runnable {
private static final Logger LOG =
LogManager.getLogger(RefreshManager.class);
+ private static final ScheduledThreadPoolExecutor REFRESH_Timer =
ThreadPoolManager.newDaemonScheduledThreadPool(1,
+ "refresh-timer-pool", true);
+ // Unit:SECONDS
+ private static final int REFRESH_TIME = 20;
+ // key is the name of a catalog, value is an array of length 2, used to
store
+ // the original refresh time and the current remaining time of the catalog
+ private static Map<String, Integer[]> refreshMap = Maps.newConcurrentMap();
Review Comment:
```suggestion
private Map<String, Integer[]> refreshMap = Maps.newConcurrentMap();
```
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/RefreshManager.java:
##########
@@ -19,26 +19,48 @@
import org.apache.doris.analysis.CreateTableStmt;
import org.apache.doris.analysis.DropTableStmt;
+import org.apache.doris.analysis.RefreshCatalogStmt;
import org.apache.doris.analysis.RefreshDbStmt;
import org.apache.doris.analysis.RefreshTableStmt;
import org.apache.doris.analysis.TableName;
import org.apache.doris.catalog.external.ExternalDatabase;
import org.apache.doris.common.DdlException;
+import org.apache.doris.common.ThreadPoolManager;
import org.apache.doris.common.UserException;
import org.apache.doris.datasource.CatalogIf;
import org.apache.doris.datasource.ExternalCatalog;
import org.apache.doris.datasource.ExternalObjectLog;
import org.apache.doris.datasource.InternalCatalog;
+import org.apache.doris.qe.DdlExecutor;
+import com.google.common.collect.Maps;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import java.util.Map;
+import java.util.concurrent.ScheduledThreadPoolExecutor;
+import java.util.concurrent.TimeUnit;
// Manager for refresh database and table action
-public class RefreshManager {
+public class RefreshManager implements Runnable {
private static final Logger LOG =
LogManager.getLogger(RefreshManager.class);
+ private static final ScheduledThreadPoolExecutor REFRESH_Timer =
ThreadPoolManager.newDaemonScheduledThreadPool(1,
+ "refresh-timer-pool", true);
Review Comment:
```suggestion
"catalog-refresh-timer-pool", true);
```
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/CatalogMgr.java:
##########
@@ -465,6 +470,20 @@ public CatalogIf replayCreateCatalog(CatalogLog log)
throws DdlException {
writeLock();
try {
CatalogIf catalog = CatalogFactory.constructorFromLog(log);
+ Map<String, String> props = log.getProps();
+ if (props.containsKey(METADATA_REFRESH_INTERVAL_SEC)) {
+ // need refresh
+ String catalogName = log.getCatalogName();
+ Integer metadataRefreshIntervalSec = null;
+ try {
+ metadataRefreshIntervalSec =
Integer.valueOf(props.get(METADATA_REFRESH_INTERVAL_SEC));
+ } catch (NumberFormatException e) {
+ throw new DdlException("Invalid properties: " +
METADATA_REFRESH_INTERVAL_SEC);
+ }
+ Integer[] sec = {metadataRefreshIntervalSec,
metadataRefreshIntervalSec};
+
Env.getCurrentEnv().getRefreshManager().getRefreshMap().put(catalogName, sec);
Review Comment:
wrap the `getRefreshMap().put(catalogName, sec)` into `RefreshManger()`.
Better not expose raw map interface outside
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
