englefly commented on code in PR #18035:
URL: https://github.com/apache/doris/pull/18035#discussion_r1145614582
##########
fe/fe-core/src/main/java/org/apache/doris/statistics/Statistics.java:
##########
@@ -95,10 +95,26 @@ public Statistics withRowCount(double rowCount) {
return statistics;
}
+ /**
+ * Update by count.
+ */
public Statistics updateRowCountOnly(double rowCount) {
- return new Statistics(rowCount, expressionToColumnStats);
+ Statistics statistics = new Statistics(rowCount,
expressionToColumnStats);
+ for (Entry<Expression, ColumnStatistic> entry :
expressionToColumnStats.entrySet()) {
Review Comment:
in updateRowCountOnly(), why update columnStats?
do you mean fix()?
##########
tools/qerror.py:
##########
@@ -119,4 +119,4 @@ def iterates_sqls(path: str, if_write_results: bool) ->
list:
iterates_sqls(original_sql_dir, False)
print("Started...")
iterates_sqls(original_sql_dir, True)
- write_results(qerr_saved_file_path, "AVG\n", [sum(q_err_list) /
len(qerror_url)])
+ write_results(qerr_saved_file_path, "AVG\n", [sum(q_err_list) /
len(q_err_list)])
Review Comment:
by the way, could you update the path which include your name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
