levy5307 commented on code in PR #17909: URL: https://github.com/apache/doris/pull/17909#discussion_r1141243301
########## be/src/runtime/fragment_mgr.cpp: ########## @@ -753,12 +753,12 @@ Status FragmentMgr::exec_plan_fragment(const TExecPlanFragmentParams& params, { SCOPED_RAW_TIMER(&duration_ns); auto prepare_st = context->prepare(params); - g_fragmentmgr_prepare_latency << (duration_ns / 1000); if (!prepare_st.ok()) { context->close_if_prepare_failed(); return prepare_st; } } + g_fragmentmgr_prepare_latency << (duration_ns / 1000); Review Comment: No, it's append-like operation. You can have a look at the func `operator<<` in `https://github.com/apache/brpc/blob/master/src/bvar/latency_recorder.cpp` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org