englefly commented on code in PR #17900:
URL: https://github.com/apache/doris/pull/17900#discussion_r1141211343


##########
regression-test/suites/nereids_syntax_p0/window_function.groovy:
##########
@@ -63,12 +63,12 @@ suite("window_function") {
     order_qt_sum "SELECT sum(c1) over(partition by c3 order by c2) FROM 
window_test"
     order_qt_avg "SELECT avg(c1) over(partition by c3 order by c2) FROM 
window_test"
     order_qt_count "SELECT count(c1) over(partition by c3 order by c2) FROM 
window_test"
-    order_qt_first_value "SELECT first_value(c1) over(partition by c3 order by 
c2) FROM window_test"
-    order_qt_last_value "SELECT last_value(c1) over(partition by c3 order by 
c2) FROM window_test"
-    order_qt_lead "SELECT lead(c1, 1, 111) over(partition by c3 order by c2) 
FROM window_test"
-    order_qt_lag "SELECT lag(c1, 1, 222) over(partition by c3 order by c2) 
FROM window_test"
-    order_qt_lead "SELECT lead(c1, 3, null) over(partition by c3 order by c2) 
FROM window_test"
-    order_qt_lag "SELECT lag(c1, 2, null) over(partition by c3 order by c2) 
FROM window_test"
+    sql "SELECT first_value(c1) over(partition by c3 order by c2) FROM 
window_test"

Review Comment:
   forget to update the corresponding .out?
   why remove the result check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to