wangbo commented on code in PR #17615: URL: https://github.com/apache/doris/pull/17615#discussion_r1139541906
########## be/src/runtime/task_group/task_group_manager.h: ########## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. +#pragma once + +#include <shared_mutex> +#include <unordered_map> + +#include "task_group.h" + +namespace doris::taskgroup { + +class TaskGroupManager { +public: + TaskGroupManager(); + ~TaskGroupManager(); + static TaskGroupManager* instance(); + + // TODO pipeline task group + TaskGroupPtr get_task_group(uint64_t id); + + static constexpr uint64_t DEFAULT_TG_ID = 0; + static constexpr uint64_t DEFAULT_TG_CPU_SHARE = 64; + + static constexpr uint64_t SHORT_TG_ID = 1; + static constexpr uint64_t SHORT_TG_CPU_SHARE = 128; + + static constexpr int32_t SHORT_QUERY_TIMEOUT_S = 40; Review Comment: How about make it a config? it can be a todo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
