TangSiyang2001 commented on code in PR #17837:
URL: https://github.com/apache/doris/pull/17837#discussion_r1138491958
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -596,20 +595,13 @@ public void checkTimeout(long now) {
killConnection = true;
}
} else {
- long timeout;
String timeoutTag = "query";
- if (userQueryTimeout > 0) {
- // user set query_timeout property
- timeout = userQueryTimeout * 1000L;
- } else {
- //to ms
- timeout = executionTimeoutS * 1000L;
- }
- //deal with insert stmt particularly
+ // insert stmt particularly
if (executor != null && executor.isInsertStmt()) {
timeoutTag = "insert";
}
-
+ //to ms
+ long timeout = executionTimeoutS * 1000L;
Review Comment:
Because `MysqlLoadManager#executeMySqlLoadJobFromStmt` seems have to use
setExecutionTimeout to directly control the kill thread behavior, if I use
getter here, will it affect the MysqlLoadManager#executeMySqlLoadJobFromStmt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
