github-actions[bot] commented on code in PR #17820:
URL: https://github.com/apache/doris/pull/17820#discussion_r1136816577
##########
be/test/olap/rowset/segment_v2/bitshuffle_page_test.cpp:
##########
@@ -39,7 +38,7 @@ class BitShufflePageTest : public testing::Test {
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/binary_prefix_page_test.cpp:
##########
@@ -75,7 +74,7 @@ class BinaryPrefixPageTest : public testing::Test {
EXPECT_EQ(slices.size(), page_decoder->count());
//check values
- MemPool pool;
+ vectorized::Arena pool;
auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
size_t size = slices.size();
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/binary_prefix_page_test.cpp:
##########
@@ -96,7 +95,7 @@
int n = 0;
while (true) {
//check values
- MemPool pool;
+ vectorized::Arena pool;
auto type_info = get_scalar_type_info(OLAP_FIELD_TYPE_VARCHAR);
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/bitshuffle_page_test.cpp:
##########
@@ -39,7 +38,7 @@
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/bitshuffle_page_test.cpp:
##########
@@ -83,7 +82,7 @@
EXPECT_TRUE(status.ok());
EXPECT_EQ(0, page_decoder.current_index());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -33,7 +32,7 @@
public:
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -33,7 +32,7 @@
public:
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'get_scalar_type_info'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -33,7 +32,7 @@
public:
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
Review Comment:
warning: variable has incomplete type 'vectorized::Arena'
[clang-diagnostic-error]
```cpp
vectorized::Arena pool;
^
```
**be/src/vec/columns/column.h:60:** forward declaration of
'doris::vectorized::Arena'
```cpp
class Arena;
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -64,7 +63,7 @@
EXPECT_EQ(0, for_page_decoder.current_index());
EXPECT_EQ(size, for_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -64,7 +63,7 @@
EXPECT_EQ(0, for_page_decoder.current_index());
EXPECT_EQ(size, for_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
Review Comment:
warning: variable has incomplete type 'vectorized::Arena'
[clang-diagnostic-error]
```cpp
vectorized::Arena pool;
^
```
**be/src/vec/columns/column.h:60:** forward declaration of
'doris::vectorized::Arena'
```cpp
class Arena;
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -64,7 +63,7 @@
EXPECT_EQ(0, for_page_decoder.current_index());
EXPECT_EQ(size, for_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
ColumnBlock block(cvb.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock block(cvb.get(), &pool);
^
```
##########
be/test/olap/rowset/segment_v2/plain_page_test.cpp:
##########
@@ -46,7 +45,7 @@ class PlainPageTest : public testing::Test {
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/plain_page_test.cpp:
##########
@@ -84,7 +83,7 @@
EXPECT_EQ(0, page_decoder.current_index());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/bitshuffle_page_test.cpp:
##########
@@ -39,7 +38,7 @@
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
ColumnBlock block(cvb.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock block(cvb.get(), &pool);
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -37,7 +36,7 @@
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
Review Comment:
warning: variable has incomplete type 'vectorized::Arena'
[clang-diagnostic-error]
```cpp
vectorized::Arena pool;
^
```
**be/src/vec/columns/column.h:60:** forward declaration of
'doris::vectorized::Arena'
```cpp
class Arena;
^
```
##########
be/test/olap/rowset/segment_v2/plain_page_test.cpp:
##########
@@ -84,7 +83,7 @@
EXPECT_EQ(0, page_decoder.current_index());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -33,7 +32,7 @@
public:
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
ColumnBlock block(cvb.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock block(cvb.get(), &pool);
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -33,7 +32,7 @@
public:
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
std::unique_ptr<ColumnVectorBatch> cvb;
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -33,7 +32,7 @@ class FrameOfReferencePageTest : public testing::Test {
public:
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
Review Comment:
warning: no template named 'TypeTraits' [clang-diagnostic-error]
```cpp
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -64,7 +63,7 @@
EXPECT_EQ(0, for_page_decoder.current_index());
EXPECT_EQ(size, for_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'get_scalar_type_info'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/frame_of_reference_page_test.cpp:
##########
@@ -64,7 +63,7 @@
EXPECT_EQ(0, for_page_decoder.current_index());
EXPECT_EQ(size, for_page_decoder.count());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, true, get_scalar_type_info(Type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/bitshuffle_page_test.cpp:
##########
@@ -83,7 +82,7 @@
EXPECT_TRUE(status.ok());
EXPECT_EQ(0, page_decoder.current_index());
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(size, false, get_scalar_type_info(Type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(size, false, get_scalar_type_info(Type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/plain_page_test.cpp:
##########
@@ -46,7 +45,7 @@
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
Review Comment:
warning: use of undeclared identifier 'ColumnVectorBatch'
[clang-diagnostic-error]
```cpp
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
^
```
##########
be/test/olap/rowset/segment_v2/plain_page_test.cpp:
##########
@@ -46,7 +45,7 @@
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
- MemPool pool;
+ vectorized::Arena pool;
std::unique_ptr<ColumnVectorBatch> cvb;
ColumnVectorBatch::create(1, true, get_scalar_type_info(type),
nullptr, &cvb);
ColumnBlock block(cvb.get(), &pool);
Review Comment:
warning: unknown type name 'ColumnBlock' [clang-diagnostic-error]
```cpp
ColumnBlock block(cvb.get(), &pool);
^
```
##########
be/test/olap/rowset/segment_v2/rle_page_test.cpp:
##########
@@ -37,7 +36,7 @@ class RlePageTest : public testing::Test {
template <FieldType type, class PageDecoderType>
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
Review Comment:
warning: no template named 'TypeTraits' [clang-diagnostic-error]
```cpp
void copy_one(PageDecoderType* decoder, typename
TypeTraits<type>::CppType* ret) {
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
