[GitHub] [doris] 924060929 commented on a diff in pull request #17790: [enhancement](nereids) update FilterEstimation and Agg in stats derive

[via GitHub]

924060929 commented on code in PR #17790:
URL: https://github.com/apache/doris/pull/17790#discussion_r1136735778


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -319,10 +320,8 @@ public String toString() {
             builder.append("#").append(ownerGroup.getGroupId().asInt());
         }
 
-        DecimalFormat decimalFormat = new DecimalFormat();
-        decimalFormat.setGroupingSize(3);
-        builder.append(" cost=").append(decimalFormat.format((long) cost));
-        builder.append(" estRows=").append(estOutputRowCount);
+        builder.append(" cost=").append(NUM_FORMAT.format((long) cost));
+        builder.append(" 
estRows=").append(NUM_FORMAT.format(estOutputRowCount));

Review Comment:
   please add synchronized block for NUM_FORMAT, because the NUM_FORMAT is a 
global variable
   
   <img width="726" alt="image" 
src="https://user-images.githubusercontent.com/8806055/225260199-bb2d4f0d-ac96-489e-84c6-ce82b9e8334e.png";>
   
   e.g.
   ```java
   synchronized(NUM_FORMAT) {
       ...
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org