github-actions[bot] commented on code in PR #17800:
URL: https://github.com/apache/doris/pull/17800#discussion_r1136605697
##########
be/src/vec/columns/predicate_column.h:
##########
@@ -300,16 +297,13 @@ class PredicateColumnType final : public
COWHelper<IColumn, PredicateColumnType<
return;
}
if constexpr (std::is_same_v<T, StringRef>) {
- if (_pool == nullptr) {
- _pool.reset(new MemPool());
- }
-
size_t total_mem_size = 0;
for (size_t i = 0; i < num; i++) {
total_mem_size += len_array[i];
}
- char* destination = (char*)_pool->allocate(total_mem_size);
+ strings.resize(strings.size() + total_mem_size);
+ char* destination = strings.data() + strings.size();
Review Comment:
warning: cannot initialize a variable of type 'char *' with an rvalue of
type 'unsigned char *' [clang-diagnostic-error]
```cpp
char* destination = strings.data() + strings.size();
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
