englefly commented on code in PR #17637:
URL: https://github.com/apache/doris/pull/17637#discussion_r1133348819
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/cost/CostModelV1.java:
##########
@@ -221,12 +221,7 @@ public Cost visitPhysicalHashJoin(
pattern2: (L join1 Agg1) join2 agg2
in pattern2, join1 and join2 takes more time, but Agg1 and agg2 can be
processed in parallel.
*/
- double penalty = HEAVY_OPERATOR_PUNISH_FACTOR
- * Math.min(probeStats.getPenalty(), buildStats.getPenalty());
- if (buildStats.getWidth() >= 2) {
- //penalty for right deep tree
- penalty += rightRowCount;
- }
+ double penalty = HEAVY_OPERATOR_PUNISH_FACTOR;
Review Comment:
1. this file is CostModelV1. if v2 will replace v1, keep the v1 untouched.
it will work for next few days
2. in V2, we still need penalty, especially heavy operator penalty. only
when the parallel parameter between child and parent is 0, the penalty is not
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
