This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new a745ab1703 [fix](schema scanner) fix query some schema table report
invalid parameter (#17626)
a745ab1703 is described below
commit a745ab1703ac042f36bc622576bacf7278f008ae
Author: WenYao <[email protected]>
AuthorDate: Fri Mar 10 08:52:09 2023 +0800
[fix](schema scanner) fix query some schema table report invalid parameter
(#17626)
Example:
SELECT ROUTINE_SCHEMA AS PROCEDURE_CAT, NULL AS
PROCEDURE_SCHEM,ROUTINE_NAME AS PROCEDURE_NAME,NULL AS NUM_INPUT_PARAMS,NULL AS
NUM_OUTPUT_PARAMS,NULL AS NUM_RESULT_SETS,ROUTINE_COMMENT AS
REMARKS,IF(ROUTINE_TYPE = 'FUNCTION', 2,IF(ROUTINE_TYPE= 'PROCEDURE', 1, 0)) AS
PROCEDURE_TYPE FROM INFORMATION_SCHEMA.ROUTINES WHERE ROUTINE_SCHEMA =
DATABASE();
ERROR 1105 (HY000): errCode = 2, detailMessage = invalid parameter
This wrong and some BI tools could not work correctly.
---
be/src/exec/schema_scanner.cpp | 4 ----
.../data/query_p0/system/test_query_sys_tables.out | 14 ++++++++++++++
.../suites/query_p0/system/test_query_sys_tables.groovy | 10 ++++++++++
3 files changed, 24 insertions(+), 4 deletions(-)
diff --git a/be/src/exec/schema_scanner.cpp b/be/src/exec/schema_scanner.cpp
index c069c43ab6..adc52d024d 100644
--- a/be/src/exec/schema_scanner.cpp
+++ b/be/src/exec/schema_scanner.cpp
@@ -84,10 +84,6 @@ Status SchemaScanner::init(SchemaScannerParam* param,
ObjectPool* pool) {
return Status::InternalError("invalid parameter");
}
- if (_columns.empty()) {
- return Status::InternalError("invalid parameter");
- }
-
RETURN_IF_ERROR(create_tuple_desc(pool));
_param = param;
diff --git a/regression-test/data/query_p0/system/test_query_sys_tables.out
b/regression-test/data/query_p0/system/test_query_sys_tables.out
index f215c4bff9..2d54217353 100644
--- a/regression-test/data/query_p0/system/test_query_sys_tables.out
+++ b/regression-test/data/query_p0/system/test_query_sys_tables.out
@@ -77,3 +77,17 @@ test_view
-- !sql --
DUP
+-- !sql --
+
+-- !sql --
+
+-- !sql --
+
+-- !sql --
+
+-- !sql --
+
+-- !sql --
+
+-- !sql --
+
diff --git
a/regression-test/suites/query_p0/system/test_query_sys_tables.groovy
b/regression-test/suites/query_p0/system/test_query_sys_tables.groovy
index 396d363882..de02013fdb 100644
--- a/regression-test/suites/query_p0/system/test_query_sys_tables.groovy
+++ b/regression-test/suites/query_p0/system/test_query_sys_tables.groovy
@@ -269,4 +269,14 @@ suite("test_query_sys_tables", "query,p0") {
def dbName = dbPrefix + i.toString()
sql "DROP DATABASE `${dbName}`"
}
+
+ // test no impl schema table
+ sql "USE information_schema"
+ qt_sql "select * from column_privileges"
+ qt_sql "select * from engines"
+ qt_sql "select * from events"
+ qt_sql "select * from routines"
+ qt_sql "select * from referential_constraints"
+ qt_sql "select * from key_column_usage"
+ qt_sql "select * from triggers"
}
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
