github-actions[bot] commented on code in PR #17444:
URL: https://github.com/apache/doris/pull/17444#discussion_r1129643774
##########
be/src/vec/exec/format/parquet/fix_length_dict_decoder.hpp:
##########
@@ -43,6 +43,17 @@
assert_cast<ColumnDictI32&>(*doris_column)
.insert_many_dict_data(&dict_items[0], dict_items.size());
}
+ if (doris_column->is_column_dictionary()) {
+ ColumnDictI32& dict_column =
assert_cast<ColumnDictI32&>(*doris_column);
+ if (dict_column.is_copy_dict_to_column() &&
dict_column.dict_size() == 0) {
+ std::vector<StringRef> dict_items;
+ dict_items.reserve(_dict_items.size());
+ for (int i = 0; i < _dict_items.size(); ++i) {
+ dict_items.emplace_back((char*)(&_dict_items[i]),
_type_length);
+ }
+ dict_column.insert_many_dict_data(&dict_items[0],
dict_items.size());
+ }
+ }
_indexes.resize(non_null_size);
_index_batch_decoder->GetBatch(&_indexes[0], non_null_size);
Review Comment:
warning: use of undeclared identifier '_indexes' [clang-diagnostic-error]
```cpp
_index_batch_decoder->GetBatch(&_indexes[0], non_null_size);
^
```
##########
be/src/vec/exec/format/parquet/fix_length_dict_decoder.hpp:
##########
@@ -43,6 +43,17 @@
assert_cast<ColumnDictI32&>(*doris_column)
.insert_many_dict_data(&dict_items[0], dict_items.size());
}
+ if (doris_column->is_column_dictionary()) {
+ ColumnDictI32& dict_column =
assert_cast<ColumnDictI32&>(*doris_column);
+ if (dict_column.is_copy_dict_to_column() &&
dict_column.dict_size() == 0) {
+ std::vector<StringRef> dict_items;
+ dict_items.reserve(_dict_items.size());
+ for (int i = 0; i < _dict_items.size(); ++i) {
+ dict_items.emplace_back((char*)(&_dict_items[i]),
_type_length);
+ }
+ dict_column.insert_many_dict_data(&dict_items[0],
dict_items.size());
+ }
+ }
_indexes.resize(non_null_size);
Review Comment:
warning: use of undeclared identifier '_indexes' [clang-diagnostic-error]
```cpp
_indexes.resize(non_null_size);
^
```
##########
be/src/vec/exec/format/parquet/fix_length_dict_decoder.hpp:
##########
@@ -43,6 +43,17 @@
assert_cast<ColumnDictI32&>(*doris_column)
.insert_many_dict_data(&dict_items[0], dict_items.size());
}
+ if (doris_column->is_column_dictionary()) {
+ ColumnDictI32& dict_column =
assert_cast<ColumnDictI32&>(*doris_column);
+ if (dict_column.is_copy_dict_to_column() &&
dict_column.dict_size() == 0) {
+ std::vector<StringRef> dict_items;
+ dict_items.reserve(_dict_items.size());
+ for (int i = 0; i < _dict_items.size(); ++i) {
+ dict_items.emplace_back((char*)(&_dict_items[i]),
_type_length);
+ }
+ dict_column.insert_many_dict_data(&dict_items[0],
dict_items.size());
+ }
+ }
_indexes.resize(non_null_size);
_index_batch_decoder->GetBatch(&_indexes[0], non_null_size);
Review Comment:
warning: use of undeclared identifier '_index_batch_decoder'
[clang-diagnostic-error]
```cpp
_index_batch_decoder->GetBatch(&_indexes[0], non_null_size);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
