github-actions[bot] commented on code in PR #15588:
URL: https://github.com/apache/doris/pull/15588#discussion_r1129316608
##########
be/src/vec/aggregate_functions/aggregate_function_orthogonal_bitmap.cpp:
##########
@@ -70,6 +70,20 @@ AggregateFunctionPtr
create_aggregate_function_orthogonal_bitmap_intersect_count
result_is_nullable);
}
+AggregateFunctionPtr
create_aggregate_function_orthogonal_bitmap_expr_calculate(
+ const std::string& name, const DataTypes& argument_types, const Array&
parameters,
+ bool result_is_nullable) {
+ return create_aggregate_function_orthogonal<AggOrthBitMapExprCal>(
Review Comment:
warning: no matching function for call to
'create_aggregate_function_orthogonal' [clang-diagnostic-error]
```cpp
return create_aggregate_function_orthogonal<AggOrthBitMapExprCal>(
^
```
**be/src/vec/aggregate_functions/aggregate_function_orthogonal_bitmap.cpp:28:**
candidate function template not viable: requires 3 arguments, but 4 were
provided
```cpp
AggregateFunctionPtr create_aggregate_function_orthogonal(const std::string&
name,
^
```
##########
be/src/vec/aggregate_functions/aggregate_function_orthogonal_bitmap.cpp:
##########
@@ -92,5 +106,10 @@
factory.register_function_both("orthogonal_bitmap_union_count",
create_aggregate_function_orthogonal_bitmap_union_count);
factory.register_function_both("intersect_count",
create_aggregate_function_intersect_count);
+ factory.register_function_both("orthogonal_bitmap_expr_calculate",
+
create_aggregate_function_orthogonal_bitmap_expr_calculate);
+ factory.register_function_both(
+ "orthogonal_bitmap_expr_calculate_count",
+ create_aggregate_function_orthogonal_bitmap_expr_calculate_count);
Review Comment:
warning: reference to type 'const
doris::vectorized::AggregateFunctionSimpleFactory::Creator' (aka 'const
function<shared_ptr<doris::vectorized::IAggregateFunction> (const
basic_string<char> &, const vector<shared_ptr<const
doris::vectorized::IDataType>> &, const bool)>') could not bind to an lvalue of
type 'doris::vectorized::AggregateFunctionPtr (const std::string &, const
doris::vectorized::DataTypes &, const doris::vectorized::Array &, bool)' (aka
'shared_ptr<doris::vectorized::IAggregateFunction> (const basic_string<char> &,
const vector<shared_ptr<const doris::vectorized::IDataType>> &, const
doris::vectorized::Array &, bool)') [clang-diagnostic-error]
```cpp
create_aggregate_function_orthogonal_bitmap_expr_calculate_count);
^
```
**be/src/vec/aggregate_functions/aggregate_function_simple_factory.h:109:**
passing argument to parameter 'creator' here
```cpp
void register_function_both(const std::string& name, const Creator&
creator) {
^
```
##########
be/src/vec/aggregate_functions/aggregate_function_orthogonal_bitmap.cpp:
##########
@@ -92,5 +106,10 @@
factory.register_function_both("orthogonal_bitmap_union_count",
create_aggregate_function_orthogonal_bitmap_union_count);
factory.register_function_both("intersect_count",
create_aggregate_function_intersect_count);
+ factory.register_function_both("orthogonal_bitmap_expr_calculate",
+
create_aggregate_function_orthogonal_bitmap_expr_calculate);
Review Comment:
warning: reference to type 'const
doris::vectorized::AggregateFunctionSimpleFactory::Creator' (aka 'const
function<shared_ptr<doris::vectorized::IAggregateFunction> (const
basic_string<char> &, const vector<shared_ptr<const
doris::vectorized::IDataType>> &, const bool)>') could not bind to an lvalue of
type 'doris::vectorized::AggregateFunctionPtr (const std::string &, const
doris::vectorized::DataTypes &, const doris::vectorized::Array &, bool)' (aka
'shared_ptr<doris::vectorized::IAggregateFunction> (const basic_string<char> &,
const vector<shared_ptr<const doris::vectorized::IDataType>> &, const
doris::vectorized::Array &, bool)') [clang-diagnostic-error]
```cpp
create_aggregate_function_orthogonal_bitmap_expr_calculate);
^
```
**be/src/vec/aggregate_functions/aggregate_function_simple_factory.h:109:**
passing argument to parameter 'creator' here
```cpp
void register_function_both(const std::string& name, const Creator&
creator) {
^
```
##########
be/src/vec/aggregate_functions/aggregate_function_orthogonal_bitmap.cpp:
##########
@@ -70,6 +70,20 @@
result_is_nullable);
}
+AggregateFunctionPtr
create_aggregate_function_orthogonal_bitmap_expr_calculate(
+ const std::string& name, const DataTypes& argument_types, const Array&
parameters,
+ bool result_is_nullable) {
+ return create_aggregate_function_orthogonal<AggOrthBitMapExprCal>(
+ name, argument_types, parameters, result_is_nullable);
+}
+
+AggregateFunctionPtr
create_aggregate_function_orthogonal_bitmap_expr_calculate_count(
+ const std::string& name, const DataTypes& argument_types, const Array&
parameters,
+ bool result_is_nullable) {
+ return create_aggregate_function_orthogonal<AggOrthBitMapExprCalCount>(
Review Comment:
warning: no matching function for call to
'create_aggregate_function_orthogonal' [clang-diagnostic-error]
```cpp
return create_aggregate_function_orthogonal<AggOrthBitMapExprCalCount>(
^
```
**be/src/vec/aggregate_functions/aggregate_function_orthogonal_bitmap.cpp:28:**
candidate function template not viable: requires 3 arguments, but 4 were
provided
```cpp
AggregateFunctionPtr create_aggregate_function_orthogonal(const std::string&
name,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
