TangSiyang2001 commented on PR #17249:
URL: https://github.com/apache/doris/pull/17249#issuecomment-1449922906
> @TangSiyang2001 thanks for suggestions. I had modified it.
>
> And I place the `Math.max` in the function `setExecTimeout`, how do you
think about these?
>
> ```
> public void setExecTimeout(int timeout) {
> executionTimeoutS = Math.max(timeout, executionTimeoutS);
> }
> ```
Thank u for adopting my idea. I just curious about that if we support a
finer-grained timeout, and some stmt will require a shorter timeout than the
default exec_timeout(currently query_timeout), in that case `max` policy in
`setExecTimeout` may not be suitable anymore, and dragging `max` to the certain
stmt will be more flexible and extensible for supporting different timeout
policy. How do you think :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
