SWJTU-ZhangLei commented on code in PR #17207:
URL: https://github.com/apache/doris/pull/17207#discussion_r1121308732
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -1758,22 +1769,27 @@ public int getAsInt() {
}
} else if (alterClause instanceof ModifyColumnClause) {
// modify column
- processModifyColumn((ModifyColumnClause) alterClause,
olapTable, indexSchemaMap);
+ boolean clauseCanLigthSchemaChange =
processModifyColumn((ModifyColumnClause) alterClause, olapTable,
indexSchemaMap);
lightSchemaChange = false;
+ if (clauseCanLigthSchemaChange == false) {
+ lightSchemaChangeWithVarcharLength = false;
+ }
} else if (alterClause instanceof ReorderColumnsClause) {
// reorder column
processReorderColumn((ReorderColumnsClause) alterClause,
olapTable, indexSchemaMap);
lightSchemaChange = false;
+ lightSchemaChangeWithVarcharLength = false;
Review Comment:
can we reuse lightSchemaChange instead of add a new flag
lightSchemaChangeWithVarcharLength?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
