github-actions[bot] commented on code in PR #17257:
URL: https://github.com/apache/doris/pull/17257#discussion_r1120048826
##########
be/src/vec/data_types/data_type_struct.h:
##########
@@ -99,13 +93,7 @@ class DataTypeStruct final : public IDataType {
Status from_string(ReadBuffer& rb, IColumn* column) const override;
std::string to_string(const IColumn& column, size_t row_num) const
override;
void to_string(const IColumn& column, size_t row_num, BufferWritable&
ostr) const override;
- // bool is_parametric() const { return true; }
- // SerializationPtr do_get_default_serialization() const override;
- // SerializationPtr get_serialization(const SerializationInfo& info) const
override;
- // MutableSerializationInfoPtr create_serialization_info(
- // const SerializationInfo::Settings& settings) const override;
- // SerializationInfoPtr get_serialization_info(const IColumn& column)
const override;
- // bool have_explicit_names() const { return have_explicit_names; }
+ bool get_have_explicit_names() const { return have_explicit_names; }
Review Comment:
warning: redefinition of 'have_explicit_names' as different kind of symbol
[clang-diagnostic-error]
```cpp
bool have_explicit_names() const { return have_explicit_names; }
^
```
**be/src/vec/data_types/data_type_struct.h:48:** previous definition is here
```cpp
bool have_explicit_names;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
