github-actions[bot] commented on code in PR #70795:
URL: https://github.com/apache/doris/pull/70795#discussion_r4641238767
##########
be/src/exec/operator/scan_operator.cpp:
##########
@@ -996,6 +998,11 @@ Status ScanLocalStateBase::_normalize_is_null_predicate(
template <typename Derived>
Status ScanLocalState<Derived>::_prepare_scanners() {
+ if (_helper.runtime_filter_nums() > 0) {
+ // Order the residual conjuncts before scanners clone them. For
example, an early RF
Review Comment:
[P1] Preserve the unsafe predicate barrier when sorting early runtime
filters. `_prepare_scanners()` now reorders the whole residual list after
`ScanLocalState::open()` appended ready RFs. For a file scan with an unsafe
predicate such as `CAST(bad_value AS INT) > 0` (which
`is_safe_to_execute_on_selected_rows()` rejects) and a ready RF on a partition
key, the RF can sort first.
`TableReader::_evaluate_partition_prune_conjuncts()` then accepts the RF,
prunes a nonmatching partition, and never evaluates the unsafe predicate;
before this change the unsafe predicate was first and blocked partition
pre-execution, preserving its error/non-deterministic semantics. Keep sorting
within safe segments or otherwise retain the unsafe-prefix fence, and add a
regression covering an early RF plus an error-preserving predicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]