suxiaogang223 commented on PR #69886:
URL: https://github.com/apache/doris/pull/69886#issuecomment-7030308101

   Local Doris `code-review` self-review: **PASS**, no unresolved findings.
   
   Candidate: b969b24a40b7a9bc29c95da3510ddccaf2e69045. Refactor diff SHA-256: 
c57e50a995f51228d335801491b145e38cb2c47501056419de05f98724d64e65.
   Base: 6a6c7529c1e61c0f1acec5ccf0d4c7b90ab36945.
   Result: PASS, one self-review round; no unresolved findings. This is not an 
independent review or a claim that pending CI has passed.
   
   Current verification: build.sh --fe with Maven cache disabled succeeded; 
preset Java runner completed 1,308 tests (zero failures/errors, one skipped); 
all 166 SPI tests passed. Three SQL suites passed on the new FE with the 
unchanged previously tested two-BE package. Full BE build/UT on the rebased 
tree awaits CI.
   
   | Checkpoint | Conclusion |
   | --- | --- |
   | 1. Goal and proof | Primary-key/partitioned/fixed/dynamic INSERT and 
overwrite are covered; selection now uses one optional fallback reason. The new 
FE passed three write suites and 1,308 related Java/SPI tests (one skipped). |
   | 2. Scope and reuse | The refactor changes three Java files, adds no 
selector class or enum, and preserves every table/storage check. Rebase keeps 
all 11 feature patches; only the combined SPI major changes to 36. |
   | 3. Concurrency | No new thread, lock or shared mutable state. Reuse 
fixed-bucket routing and GATHER for dynamic state. Config-mutating SQL suites 
remain nonConcurrent; the two-BE failure case actually ran. |
   | 4. Lifecycle | Writer stop/close, prepared-file ACK ownership and resource 
release are unchanged. The identical writer/test sources passed 33 ASAN cases 
before rebase, including eight fixed/dynamic PK cleanup/resource cases. |
   | 5. Configuration | No new knobs or default changes in this refactor. 
Existing writer budgets/concurrency remain mutable online. The Rust-only PK 
sort-buffer cap stays 8 MiB, preserving smaller table settings. |
   | 6. Compatibility | Accepted mixed-version requests may return errors; 
upgrading all FEs/BEs is required. The combined connector SPI is API36; all 166 
SPI tests passed. No dependency/toolchain or feature storage-format changes. |
   | 7. Thrift and Protobuf | Compared all five touched definitions on current 
HEAD, master and four maintained release refs after refreshing them. Shared 
IDs/names/types/optionality match; additions are optional. Descriptor field 7 
stays reserved; scan field 43 has no collision. |
   | 8. Parallel paths | JNI retains first-row, changelog mutations, defaults, 
CHAR padding, unsupported features/storage and refreshable credentials. Shared 
read/write descriptors and upstream native split-refinement changes are 
preserved. Mixed JNI/Rust histories and Rust reads passed in SQL. |
   | 9. Conditions and errors | Backend choice no longer compares diagnostic 
strings. Fallback priority and exact Profile reason strings remain unchanged. 
Unit tests cover append/overwrite, disabled writer, changelog and first-row; 
existing table-option/credential/type tests pass. |
   | 10. Coverage | The preset FE runner completed 1,308 tests across 141 
classes: zero failures/errors, one skipped, including all 37 SPI classes/166 
tests. Three SQL suites passed using the current FE and the previously tested 
unchanged BE binary. Full native rebuild on the rebased tree awaits CI. |
   | 11. Results | No .out or regression source changes in this refactor. The 
18 new result groups were previously runner-generated and independently 
checked; normal comparison passed again. Java tests decode/round-trip the v14 
fixture; no handwritten fixture replacement. |
   | 12. Observability | Keep supported_append/supported_overwrite and precise 
fallback reasons, backend identity, memory counters, timings and transaction 
states. Actual SQL Profiles assert Rust/JNI, COMPLETE and COMMITTED. No new 
per-row logging. |
   | 13. Transactions and persistence | FE remains the sole snapshot committer; 
reuse existing commit/abort/reconciliation. No new EditLog/image state. Durable 
recovery of in-flight external transactions across FE death remains outside the 
accepted scope. |
   | 14. Atomicity and cleanup | The two-BE failure, PK precommit failure, 
postcommit retry and unknown-outcome cases passed. Confirmed failures remove 
new files; unknown outcomes preserve them; retry does not create a second 
snapshot. Crashes/deletion failures may still leave orphan files as previously 
documented. |
   | 15. FE/BE propagation | No new transmitted variable in this refactor. 
Existing shared table descriptors, OVERWRITE mode and Java v14 commit transport 
are unchanged. The changed selection helper is internal to the connector. |
   | 16. Performance and memory | Selection runs once during planning and 
avoids two string comparisons; no data-path copy or allocation change. Existing 
estimated admission/partial SDK reservations remain, without a complete RSS 
limit, Doris spill or memory revocation. Smaller sort buffers can increase file 
counts; no throughput claim. |
   | 17. Other checks | Current FE package, Checkstyle, header hygiene and SPI 
surface-union check passed. Native feature sources match the previously tested 
code; prior format16/tidy evidence is retained at that code version. Current 
full BE integration is explicitly left for buildall, not claimed passed. No 
unresolved code finding within the accepted scope. |
   
   <!-- doris-repo-review:v1:begin -->
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#69886
   commit: b969b24a40b7a9bc29c95da3510ddccaf2e69045
   base: 6a6c7529c1e61c0f1acec5ccf0d4c7b90ab36945
   reviewed_at: 2026-11-20T04:20:06+00:00
   reviewer: suxiaogang223
   model: gpt-6.1-sol
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to