Gabriel39 commented on code in PR #70176:
URL: https://github.com/apache/doris/pull/70176#discussion_r4637468804


##########
fe/fe-core/src/main/java/org/apache/doris/arrowflight/FlightSqlSchemaHelper.java:
##########
@@ -168,7 +168,7 @@ protected static byte[] getSerializedSchema(List<Field> 
fields) {
      */
     public void setParameterForGetTables(CommandGetTables command) {
         includeSchema = command.getIncludeSchema();
-        catalogFilterPattern = command.hasCatalog() ? command.getCatalog() : 
"internal";
+        catalogFilterPattern = command.hasCatalog() ? command.getCatalog() : 
null;
         dbSchemaFilterPattern = command.hasDbSchemaFilterPattern() ? 
command.getDbSchemaFilterPattern() : null;

Review Comment:
   Addressed by carrying raw-schema mode through Flight's listTableStatus and 
describeTables calls. The new overloads bypass the MySQL inverse transformation 
while the original Thrift entry points retain it. 
FrontendServiceFlightRawSchemaTest exercises a.b through the real 
helper/service path with both display settings and both include-schema modes.



##########
fe/fe-connector/fe-connector-adbc/src/main/java/org/apache/doris/connector/adbc/AdbcConnectorMetadata.java:
##########
@@ -69,8 +69,7 @@ public class AdbcConnectorMetadata implements 
ConnectorMetadata {
     private final AdbcMetadataCache cache;
 
     /**
-     * @param dialect resolved lazily, because only the {@code executeSchema} 
fallback needs it and

Review Comment:
   Addressed with an explicit scoped compatibility path. For an older Doris 
endpoint without vendor SQL info, sql_dialect=doris now selects SELECT 
CURRENT_CATALOG() plus catalog-qualified SHOW DATABASES/SHOW FULL TABLES, 
avoiding unrestricted GetObjects. This also handles the native driver's generic 
Flight SQL vendor default. Both new cases fail before the fix with the 
recursive-GetObjects assertion and pass afterwards. Known non-Doris vendors 
retain standard discovery; the property documentation records the required 
older-server setting.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to