wyxxxcat opened a new pull request, #70772: URL: https://github.com/apache/doris/pull/70772
### Background Cloud builds with BUILD_CHECK_META can run a metadata consistency check. MetaChecker opens a MySQL connection to the requested FE for the check. ### What problem does this PR solve? Issue Number: None Related PR: #33499 (introduced the credential logging) PR Type: Bugfix Problem Summary: A failed MySQL connection caused MetaChecker to include the supplied database password in a WARNING. The warning now records the numeric MySQL error code, host, port, user, and instance ID. ### Details - **Frequency:** Always when mysql_real_connect fails in this code path. - **Root cause:** MetaChecker::init_mysql_connection streamed the password into the warning. - **Why existing tests missed it:** Cloud unit tests do not exercise this warning. The check_meta and table-stream orphan regression cases check the consistency results and HTTP response after connecting to FE. - **Fix:** Record the numeric MySQL error code and endpoint context in the warning. Use the password only in the MySQL connection attempt. - **Other paths and branches:** This is the only MetaChecker connection-failure warning. Local branch-4.0 and branch-4.1 refs contain the same logging statement. The branch-3.1 and branch-4.2 refs were unavailable locally. - **Behavior change:** The connection-failure warning uses a numeric code and omits the password and free-form MySQL error text. ### Testing - A local loopback fixture compiled the production method against MySQL and glog. The baseline warning contained the synthetic password and failed the assertion. The patched warning passed with the endpoint, instance ID, and MySQL error code 2003. - Repository clang-format 16 scripts passed for the changed C++ file. - Cloud ASAN build passed with BUILD_CHECK_META=ON. - Cloud clang-tidy passed on the changed lines with the toolchain resource directory supplied. ### Release note MetaChecker keeps database passwords out of MySQL connection-failure warnings. ### Check List (For Author) - Behavior changed: Yes (see Details) - Does this need documentation: No - Pre-submission status: Partially verified: the connection warning was tested locally and the Cloud build passed. The cluster HTTP path and regression suites were not run. ### AI Disclosure - Tool: Codex (GPT-6) - Generated: C++ fix, temporary verification fixture, and this description - Human review: Pending <!-- Recommended: develop the change with the develop-with-evidence skill and write this description with the doris-pr-description skill, both from https://github.com/apache/doris-skills (the doris-skills submodule of this repository). --> ### Background <!-- How the feature or module this PR touches works today, in two to four plain sentences, for a reviewer who doesn't know it. Link the user doc if there is one. Leave the problem and the fix to Problem Summary. --> ### What problem does this PR solve? <!-- Issue Number: "close #N" if this PR resolves the issue, "#N" if it only relates to it, "None" if there is none. A Feature needs an issue. --> <!-- Related PR: "#N (relation)" for each PR a reviewer should know about, such as "#123 (introduced the bug)", separated by commas. Write "None" if no related PR is known. --> <!-- PR Type: Bugfix, Performance, Feature, Enhancement, Refactor, Test, Build/CI/Chore, Revert, Release/Dependency, or Other. --> Issue Number: Related PR: PR Type: Problem Summary: <!-- Two to five sentences: the problem or need and who is affected; the approach in one sentence; when the diff is larger than that suggests, what else it had to handle, or that most of it is tests; and what existing users see after an upgrade. --> ### Details <!-- For a diff of more than about 300 changed lines, start with "- **Change map:**": how many lines are production code, tests, generated files, and docs, then the code in parts, each with the problem it handles and its size. Then answer each field of your PR type on its own line, as "- **Field:** answer", in this order: Bugfix: Frequency, Root cause, Why existing tests missed it, Fix, Other paths and branches Performance: Why it was slow, Optimization, Results, Applicability and cost Feature: Scope, Design, Usage, Default behavior, Compatibility Enhancement: Before and after, Configs and defaults, Impact on existing users Refactor: Moves vs. logic changes, Behavior change, Compatibility, Performance impact, Rollback Test, adding tests: Scenarios, What existing tests miss, Fails when broken Test, fixing a test: Failure, Cause, Stability evidence Build/CI/Chore: Affected, Developer and release impact, License and third-party, Rollback Revert: Why not fix forward, Original author notified, Follow-up Release/Dependency: Versions, Upstream changes, Compatibility, Rollback Other: Why Other "None" is a valid answer when it is true. Don't restate the diff. --> ### Testing <!-- The tests, suites, or commands that ran, what each shows, and where it ran (locally or in CI). For a fix, the test that fails before it and passes after. --> ### Notes for Reviewers <!-- Optional; delete this section if there is nothing to say. Why each non-obvious edit was made, what you are unsure about, and where to start reading if Details has no Change map. --> ### Release note <!-- One paragraph on what users will notice, or None. --> ### Check List (For Author) <!-- Behavior changed: "No", or "Yes (see Details)" with a Behavior change field in Details. --> <!-- Does this need documentation: "No", or "Yes" with the apache/doris-website PR or the plan. --> <!-- Pre-submission status: "Ready"; "Partially verified: " and what is not verified; or "Not ready: " and why, for a Draft PR. --> - Behavior changed: - Does this need documentation: - Pre-submission status: ### AI Disclosure <!-- Tool: the agent and model, or None. Generated: the parts it wrote (code, tests, this description), or None. Human review: what you reviewed of the generated parts, or "Not applicable" without AI tools. You may add "- Prompts:" to summarize how you directed the agent. --> - Tool: - Generated: - Human review: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
