github-actions[bot] commented on code in PR #70763:
URL: https://github.com/apache/doris/pull/70763#discussion_r4629152064
##########
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java:
##########
@@ -1035,23 +1035,23 @@ public static double getHotValueThreshold() {
public static final String ANN_INDEX_CANDIDATE_ROWS_PERCENT_THRESHOLD =
"ann_index_candidate_rows_percent_threshold";
- public static final String DEFAULT_VARIANT_MAX_SUBCOLUMNS_COUNT =
"default_variant_max_subcolumns_count";
+ public static final String DEBUG_VARIANT_MAX_SUBCOLUMNS_COUNT =
"debug_variant_max_subcolumns_count";
Review Comment:
[P2] Prevent debug-only VARIANT values from surviving a production image
load. `SessionVariable.toJson()` serializes every `@VarAttr`, so `SET GLOBAL
debug_variant_enable_doc_mode=true` while `enable_debug_points=true` stores
this renamed key in the image. Restarting with `enable_debug_points=false` lets
`readFromJson()` restore it without `checkDefaultVariantSettable`; the later
replay catches that checker failure and leaves the value true. A fresh session
inherits the non-default value, and both `UNSET VARIABLE ALL` and `UNSET GLOBAL
VARIABLE ALL` then fail when they try to reset it through the same checker.
Normalize or drop debug-only fields during image load when debug points are
disabled, and add an image round-trip reset test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]