github-actions[bot] commented on code in PR #70760:
URL: https://github.com/apache/doris/pull/70760#discussion_r4628685280
##########
cloud/src/meta-service/delete_bitmap_lock_white_list.h:
##########
@@ -38,6 +38,15 @@ class DeleteBitmapLockWhiteList {
void update_white_list(std::string white_list);
std::string get_delete_bitmap_lock_version(std::string instance_id);
+ template <typename LockContext>
+ std::string get_delete_bitmap_lock_version(const std::string& instance_id,
+ const LockContext& context) {
+ if (context.has_enable_delete_bitmap_lock_v2()) {
Review Comment:
[P1] Preserve the table lock protocol for omitted fields during rolling
upgrades. This overload falls back to the instance whitelist when
`enable_delete_bitmap_lock_v2` is absent. A v2 compaction/schema-change job
stores its lock in the `mow_tablet_job` namespace, but an older worker retrying
or aborting that job sends no field; with the default v1 whitelist, Meta
Service selects v1 and `check_delete_bitmap_lock` searches the v1 initiator
list, returns `LOCK_EXPIRED`, and leaves the job/lock stranded. Either derive
the mode from the persisted table/job record for legacy requests or gate
creation until all workers support the field, and add a mixed-version takeover
test.
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -301,6 +301,7 @@ public class PropertyAnalyzer {
// For the detail design, see the
[DISP-018](https://cwiki.apache.org/confluence/
//
display/DORIS/DSIP-018%3A+Support+Merge-On-Write+implementation+for+UNIQUE+KEY+data+model)
public static final String ENABLE_UNIQUE_KEY_MERGE_ON_WRITE =
"enable_unique_key_merge_on_write";
+ public static final String ENABLE_DELETE_BITMAP_LOCK_V2 =
"enable_delete_bitmap_lock_v2";
Review Comment:
[P2] Document `enable_delete_bitmap_lock_v2` in the cloud CREATE
TABLE/property reference. Users need the default (`true` for new cloud MoW
tables), explicit `false`, ALTER rejection, legacy-table whitelist fallback,
and the requirement to upgrade all FE/BE/Meta Service/Recycler components
before creating tables that use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]