yujun777 commented on PR #69850:
URL: https://github.com/apache/doris/pull/69850#issuecomment-7006040050

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#69850
   commit: a4b6c2cb8de7e67d18ce1159e9a0b5f0c44f6e35
   base: ee73acc6131e6c6c752eb59e252404590be6ad77
   reviewed_at: 2026-11-19T18:09+08:00
   reviewer: yujun777
   model: gpt-6.1-sol
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - 
`fe/fe-core/src/main/java/org/apache/doris/catalog/stream/StreamRowCountEstimator.java:44`
 — Estimates remain asynchronous approximations across reporting lag and TTL 
reclamation; they are not a TSO-exact upper bound.
   - 
`fe/fe-core/src/test/java/org/apache/doris/nereids/stats/StreamScanRowCountTest.java:417`
 — Current development logs record 46 focused FE tests with zero 
failures/errors/skips and a successful FE build with zero Checkstyle 
violations. Reviewers read those logs without running builds/tests; earlier 
native and SN results retain their original head and unchanged-code scope.
   - `cloud/test/meta_service_table_stream_test.cpp:1043` — The new baseline 
protocol has mocked FE RPC and in-memory Meta Service coverage; this review 
does not establish a live Cloud/FDB baseline round trip, real process 
restart/FE failover, current combined companion binary or performance benchmark.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to