yiguolei commented on PR #70738:
URL: https://github.com/apache/doris/pull/70738#issuecomment-7003496259
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70738
commit: 75457521ca95614945630b3b659022e648d676db
base: 601b259ce51d80e600504263ec581c23913091dc
reviewed_at: 2026-11-19T16:10+08:00
reviewer: yiguolei
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
- Source review covered all 14 changed files and converged in one round; no
actionable findings. No builds or tests were run in this independent review.
- `be/src/storage/segment/column_reader_cache.cpp:74` — Identity-checked
eviction preserves concurrent replacements; insertion keeps one LRU/map node
per key.
- `be/src/storage/segment/variant/variant_column_reader.cpp:1505` —
External-metadata failures retire the reader on later acquisition; existing
references intentionally remain failed. Healthy-hit traversal cost is disclosed
in the PR and was not benchmarked.
<sub>Reviewed locally with the `doris-repo-review` pipeline. Repository
policy may accept this receipt for the matching commit; it is not a human
Apache approval.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]