github-actions[bot] commented on code in PR #70744:
URL: https://github.com/apache/doris/pull/70744#discussion_r4625676033


##########
be/src/core/column/column_complex.h:
##########
@@ -238,16 +238,6 @@ class ColumnComplexType final : public COWHelper<IColumn, 
ColumnComplexType<T>>
         data[self_row] = assert_cast<const Self&, 
TypeCheckOnRelease::DISABLE>(rhs).data[row];
     }
 
-    void erase(size_t start, size_t length) override {

Review Comment:
   [P1] Remove the remaining ColumnComplex erase test
   
   The unchanged `TEST(ColumnComplexTest, TestErase)` in 
`be/test/core/block/column_complex_test.cpp:692-708` still calls 
`column_test->erase(1, 0)` and `erase(3, 1)`. With both this override and 
`IColumn::erase` removed, `ColumnComplexType<TYPE_BITMAP>` has no `erase` 
member, so that translation unit cannot compile. `be/test/CMakeLists.txt` 
recursively includes `core/*.cpp` in `doris_be_test`, so the BE unit-test 
target is broken. Remove or migrate this caller alongside the other erase tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to