suxiaogang223 commented on PR #70566:
URL: https://github.com/apache/doris/pull/70566#issuecomment-7002015094
PASS — local Doris code-review completed for
`9eae24dc3edc3ea29bc8136b26cb3389805021a4` against
`fda8d83426ae45bdf1bfef2f331846bbe9af7826`.
Resolved the three failures from the previous external run: replaced the
obsolete Paimon branch-write rejection with successful append/overwrite and
Spark/main/tag/history checks, matched the shared static-partition error, and
restored the established Iceberg invisible-column diagnostic for INSERT SELECT.
The latest full schema is consulted only for invisible metadata; visible write
columns remain bound to the explicit target. The VALUES path already has this
behavior. Rebased onto the latest master, preserved its scan SPI additions, and
advanced this feature to plugin API 36.0 because master now uses 35.0. No
outstanding findings remain after reviewing the follow-up and its interaction
with the prior full-feature review.
Part 1.3 checkpoint conclusions:
1. Goal: all three observed failures are addressed; the tightened binder
regression reproduces the production defect before the fix.
2. Scope: one production line, its unit regression/boundary test, and two
Paimon suites, plus API-version alignment after rebase; no unrelated edits.
3. Concurrency: no new threads, locks or shared state; latest metadata is
diagnostic only.
4. Lifecycle: target ownership/reset/copy and existing resource lifecycles
remain intact.
5. Configuration: no new configuration; external CI selects both modified
suites.
6. Compatibility: no additional API, storage or wire changes beyond the
reviewed plugin API 36.0 feature; both upstream scan and new write interfaces
are retained.
7. Thrift/Proto: no definitions changed.
8. Parallel paths: SELECT now matches VALUES hidden-column rejection;
default-column/rewrite and sink-binding cases pass.
9. Conditions: hidden names reject explicitly, while visible names outside
the pinned schema remain unknown; no silent continuation.
10. Coverage: 497 tests pass (SPI 167, Paimon 123, Iceberg 110, FE 97) with
zero failures, errors or skips; live-cluster SQL awaits external CI.
11. Results: no handwritten regression outputs; ordered actual-state and
cross-engine comparisons retain isolation checks.
12. Observability: the established named-column diagnostic is restored
before writer creation; existing transaction/branch diagnostics remain.
13. Persistence/failover: no EditLog or recovery changes; crash/failover
injection was not run.
14. Writes/atomicity: invalid target columns fail before writing; branch
tests preserve main/tag/history and the failure suite retains snapshot
atomicity assertions.
15. FE-BE: no new fields or sending paths; native target serialization is
unchanged.
16. Performance: fallback is limited to explicit names missing from the pin;
no per-row work added.
17. Other: no remaining actionable findings, debug mutations, discussion
documents, environment edits or submodule-pointer changes.
Verification: `run-fe-ut.sh` completed the selected 91-module reactor and
497 tests, including all 37 SPI test classes. The same tightened hidden-column
test failed on the pre-fix production code with the exact unknown-column
diagnostic from CI. Checkstyle passed on all 30 changed Java files; both
modified Paimon scripts and the existing Iceberg lineage script parse with
Groovy 4.0.19; whitespace checks passed. Paimon packaging also passed 19
target/REST tests; the ZIP contains API 36.0, the native target class and the
generation-validation reference. The final committed tree exactly matches the
source tree used by the unit run; message-only rewording preserved it. The
previous CI retry exposed an independently confirmed TeamCity agent failure
when setting executable attributes on temporary scripts, and a master-merge
conflict now resolved by this rebase. This PASS is a code-review conclusion; it
does not claim post-fix external SQL execution has completed.
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#70566
commit: 9eae24dc3edc3ea29bc8136b26cb3389805021a4
base: fda8d83426ae45bdf1bfef2f331846bbe9af7826
reviewed_at: 2026-11-19T06:49:01.290433+00:00
reviewer: suxiaogang223
model: gpt-6.1-sol
effort: xhigh
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]