yujun777 commented on PR #70561:
URL: https://github.com/apache/doris/pull/70561#issuecomment-6998804299

   <!-- doris-repo-review:v1:begin -->
   ### Local pipeline review — ✅ PASS
   
   ```yaml
   schema: doris-repo-review/v1
   status: PASS
   pr: apache/doris#70561
   commit: 71244e29251a4526230fae8d9b35648f6bc48698
   base: 098d0bb62bbc82d9bd999d391efe1c20df89930b
   reviewed_at: 2026-11-19T11:29+08:00
   reviewer: yujun777
   model: gpt-6.1-sol
   effort: xhigh
   findings: {blocker: 0, major: 0, minor: 0, nit: 0}
   rounds: 1
   converged: true
   ```
   
   **Notes for maintainers**
   
   - 
`fe/fe-core/src/main/java/org/apache/doris/mtmv/ivm/IvmJoinDeltaHandler.java:256`
 — The shared value-preserving grouping gate covers both unique SUM and 
nonunique key-event repair; unsafe pure equality keys use the original full-ON 
SEMI/ANTI incremental path in LEFT, RIGHT and FULL joins.
   - 
`regression-test/suites/mtmv_p0/ivm/test_ivm_unique_key_null_repair.groovy:252` 
— Four FLOAT/DOUBLE signed-zero cases check exact repair branches and 12 
independent bag differences. Supplied validation includes 193 FE tests, normal 
comparison of 128 non-Cloud IVM suites, and a Cloud generation run whose 
complete output matches the committed golden. Reviewers did not rerun builds or 
tests.
   
   <sub>Reviewed locally with the `doris-repo-review` pipeline. Repository 
policy may accept this receipt for the matching commit; it is not a human 
Apache approval.</sub>
   <!-- doris-repo-review:v1:end -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to